AbstractClassRestrictions: improve how anonymous classes are handled #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `AbstractClassRestrictionsSniff::is_targetted_token()` would name an anonymous class as "\class" or "\readonly" (in the case of readonly anonymous classes). While this would not cause false positives as it is not possible for a class to be named "class" or "readonly", it is not the correct behavior. This commit improves how this method handles anonymous classes by returning `false` early as those classes don't have a name. Includes tests for readonly anonymous classes. It was not necessary to include more tests for normal anonymous classes as the existing tests are already enough.
rodrigoprimo
added
Type: Enhancement
Status: Review ready
Type: Chores/Cleanup
and removed
Type: Enhancement
labels
jrfnl
approved these changes
Jul 18, 2025
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks @rodrigoprimo ! Two nitpicky remarks, but nothing blocking.
Collaborator
Author
|
Thanks for your review, @jrfnl. I just added your suggestions. |
Co-authored-by: Juliette <[email protected]>
rodrigoprimo
force-pushed
the
abstract-class-restrictions-sniff
branch
from
a34554d to
d79af5e
Compare
Collaborator
Author
|
Force pushed without changes to run the GitHub actions again as they failed with the PHPStan not found error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
AbstractClassRestrictionsSniff::is_targetted_token()would name an anonymous class as "\class" or "\readonly" (in the case of readonly anonymous classes). While this would not cause false positives as it is not possible for a class to be named "class" or "readonly", it is not the correct behavior.This commit improves how this method handles anonymous classes by returning
falseearly, as those classes don't have a name.Includes tests for readonly anonymous classes. It was not necessary to include more tests for normal anonymous classes, as the existing tests are already enough.