DB/RestrictedClasses: remove redundant call to parent::setUpPrerequisites()
#2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sites()` Calling `AbstractSniffUnitTest::setUpPrerequisites()` manually inside `RestrictedClassesUnitTest::enhanceGroups()` is not necessary as this method already executes via its `@before` tag and results in the method running twice. Originally, `RestrictedClassesUnitTest::enhanceGroups()` was named `RestrictedClassesUnitTest::setUp()` and called `parent::setUp()` (https://github.com/WordPress/WordPress-Coding-Standards/blob/3b9ae92607295548df357e108fd27090cf89d1d7/WordPress/Tests/DB/RestrictedClassesUnitTest.php#L34-L35). But later it was renamed, and then it probably didn't make sense to continue calling `parent::setUp()` (which was later renamed to `setUpPrerequisites()`): WordPress@00b895c. I found this in the context of the work to prepare this codebase for PHPCS 4.0 as `AbstractSniffUnitTest::setUpPrerequisites()` was renamed in 4.0 (PHPCSStandards/PHP_CodeSniffer@92cf10f#diff-91ba2a2a923bbfdaa61dcd31051d783bd0e7ff99f979f6e1a2917cae7dde3eb2L58).
jrfnl
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
Good find @rodrigoprimo and good explanation.
While this fix is valid as-is for the current codebase, I want to point out that this will need to be brought back again once support for PHPCS 3.x will be dropped.
Reasoning:
- Drop PHPCS 3.x means => drop support for PHP 7.2 means => no need to support PHPUnit 4-7 anymore.
- Once support for PHPUnit 4-7 has been dropped, we can remove the
@before/@afterannotations and start using the normalsetUp()/tearDown()methods again (as the required return typevoidis no longer a problem), in which case, we will need to callparent::setUp()again.
Not sure if you already have some commits in your WIP branch for the follow ups (add cross-version PHPCS 3/4 support => drop support for PHP < 7.2 => drop support for PHPUnit < 8 => drop support for PHPCS 3.x => add support for PHPUnit 10+11). If so, please make sure you add it back in the appropriate follow-up commit.
Otherwise, we should maybe make a note of this somewhere ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
AbstractSniffUnitTest::setUpPrerequisites()manually insideRestrictedClassesUnitTest::enhanceGroups()is not necessary, as this method already executes via its@beforetag and results in the method running twice.Originally,
RestrictedClassesUnitTest::enhanceGroups()was namedRestrictedClassesUnitTest::setUp()and calledparent::setUp()(WordPress/Tests/DB/RestrictedClassesUnitTest.php#L34-L35). But later it was renamed, and then it probably didn't make sense to continue callingparent::setUp()(which was later renamed tosetUpPrerequisites()): 00b895c.I found this in the context of the work to prepare this codebase for PHPCS 4.0 as
AbstractSniffUnitTest::setUpPrerequisites()was renamed in 4.0 (PHPCSStandards/PHP_CodeSniffer@92cf10f#diff-91ba2a2a923bbfdaa61dcd31051d783bd0e7ff99f979f6e1a2917cae7dde3eb2L58).