Skip to content

ConstantsHelper::is_use_of_global_constant(): do not treat use const alias as global constant usage #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

ConstantsHelper::is_use_of_global_constant(): do not treat use const alias as global constant usage #2579

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58836a8
ConstantsHelper::is_use_of_global_constant(): do not treat `use const…
rodrigoprimo Aug 15, 2025
ea416f0
Add comment clarifying that this specific test is now an exception in…
rodrigoprimo Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WordPress/Helpers/ConstantsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public static function is_use_of_global_constant( File $phpcsFile, $stackPtr ) {
\T_INSTANCEOF => true,
\T_INSTEADOF => true,
\T_GOTO => true,
\T_AS => true,
);
$tokens_to_ignore += Tokens::$ooScopeTokens;
$tokens_to_ignore += Collections::objectOperators();
Expand Down
1 change: 0 additions & 1 deletion WordPress/Tests/WP/DiscouragedConstantsUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public function getWarningList() {
60 => 1,
61 => 1,
63 => 1,
64 => 1,
66 => 1,
67 => 1,
71 => 1,
Expand Down
Loading