WP/GlobalVariablesOverride: more tests covering unresolvable $GLOBALS keys
#2580
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Aug 21, 2025
| // This has to be the last test in the file! | ||
| list( $tab, $tabs | ||
| /* | ||
| * $GLOBALS with non-string key, unable to determine if it is a global variable override or not. |
There was a problem hiding this comment.
Ahum... it's definitely a global variable override, we just don't know whether it is one we should flag.
Suggested change
| * $GLOBALS with non-string key, unable to determine if it is a global variable override or not. | |
| * $GLOBALS with non-string key, unable to determine which variable is being overridden. |
Comment on lines
+317
to
+324
| $GLOBALS[ "some{$name}" ] = 'test'; // Ok. | ||
| $GLOBALS[ $obj->global_name ] = 'test'; // Ok. | ||
| $GLOBALS[ MyClass::GLOBAL_NAME ] = 'test'; // Ok. | ||
| $GLOBALS[ GLOBAL_NAME_CONSTANT ] = 'test'; // Ok. | ||
| $GLOBALS[ get_my_global_name() ] = 'test'; // Ok. | ||
| $GLOBALS[ MyNamespace\get_my_global_name() ] = 'test'; // Ok. | ||
| $GLOBALS[ \MyNamespace\get_my_global_name() ] = 'test'; // Ok. | ||
| $GLOBALS[ namespace\get_my_global_name() ] = 'test'; // Ok. |
There was a problem hiding this comment.
Please wrap this test code within a simple function declaration to prevent it potentially affecting other tests in the file. (I vaguely remember we had issues with this in the past, better to prevent new ones in the future ;-) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for cases where the
WordPress.WP.GlobalsVariableOverridesniff is not able to resolve the value of$GLOBALSkeys. It also includes a separate commit moving a parse error test to a separate file.