Docs: Add documentation for WordPress.PHP.TypeCasts

[brentwilson-clariio]

Related to #1722

This PR adds a new documentation file:
WordPress/Docs/PHP/TypeCastsStandard.xml

What it covers

Documents the rule enforced by the WordPress.PHP.TypeCasts sniff:

• Normalizes legacy float casts ((double), (real)) to (float).

Notes

Other type-cast related rules in the WordPress standard are enforced by separate sniffs:

• Short form keywords ((int), (bool), (string)): PSR12.Keywords.ShortFormTypeKeywords
• No spaces inside parentheses: Squiz.WhiteSpace.CastSpacing
• Exactly one space after the cast: Generic.Formatting.SpaceAfterCast

[jrfnl]

@brentwilson-clariio Thanks for picking this up! I've just had a quick look and left some feedback for you to consider.

[jrfnl]

This whole block doesn't belong here. Each sniff functions independently of other sniffs. That also means that the docs should be independent of each other and should just focus on what this sniff does.

[brentwilson-clariio]

Thanks! I’ve removed the paragraph referencing other sniffs. The docs now only describe what WordPress.PHP.TypeCasts enforces.

[jrfnl]

PHP open tag is not needed here. (Same for the "invalid" code sample)

[brentwilson-clariio]

Removed <?php from all code samples as suggested.

[jrfnl]

This sentence seems redundant.

[brentwilson-clariio]

Reworded the opener to be shorter and clearer. It now states the rules enforced without repeating itself.

[jrfnl]

Suggested change

	<documentation title="Type Casts">
	<?xml version="1.0"?>
	<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
	title="Type Casts"
	>

[brentwilson-clariio]

Added the schema header and xsi:noNamespaceSchemaLocation pointing to phpcsdocs.xsd.

[jrfnl]

This is incorrect/incomplete.

The sniff:

• Forbids the use of non-standard casts for floats.
• Forbids the use of the (unset) cast.
• Discourages the use of the (binary) cast.

Considering the above, I believe the code samples also need work.

[brentwilson-clariio]

Updated the standard text and the code examples to cover all three behaviors:
• (double)/(real) → error (normalize to (float))
• (unset) → error (removed in PHP 8.0; suggest unset())
• (binary) → warning (discouraged)

[jrfnl]

Suggested change

	<code title="Invalid: legacy float casts">
	<code title="Invalid: Using legacy float casts.">

[brentwilson-clariio]

Adjusted the code block titles to your suggested wording.

[jrfnl]

Suggested change

	<code title="Valid: normalized float cast">
	<code title="Valid: Using normalized float casts.">

[brentwilson-clariio]

Adjusted the code block titles to your suggested wording.

[brentwilson-clariio]

Updated code block titles to “Valid: Using normalized float casts.” (and similar phrasing for the other examples), as suggested.

[jrfnl]

The code comparison should have "valid" on the left (first code sample), "invalid" on the right (second code sample).

[brentwilson-clariio]

Thanks for the feedback! I’ve reordered the code examples so that Valid is on the left and Invalid is on the right, as suggested.