-
-
Notifications
You must be signed in to change notification settings - Fork 518
CONTRIBUTING: make it clear that AI-generated PRs are not welcome #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Includes a pull request template which also warns against this. For the rationale behind this, please read the text in the CONTRIBUTING guide.
eb9f6ff
to
b4b8644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few change suggestions.
Thanks for the review @dingo-d, applied nearly everything, left comments on what I didn't. Note for whomever merges this: please SQUASH-merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't support the framing of the changes here. It's too negative. It's too threatening, and while I understand the premise behind this change, I don't like it.
If a contributor has taken the time to look up the contributing documentation or read the comments in a PR template, then they are likely more conscientious than the individuals who send in PRs that appear to be generated by AI. In other words, the people these threats are aimed at are not the ones who will be reading these changes.
This change would only seemingly exist to grant us the permission to ban people from the repository. If someone is persistent in sending in low-quality PRs, then we already have the Code of Conduct process to follow.
Instead of "Words of Warning", let's frame it as "Tips for a successful PR", and then explain how the use of AI will nearly always lead to a poor changeset, and the impact on maintainers' time. We can still get the points across, and still have a section to point AI-generated PR authors to, without needing to litter our docs with threats of bans.
@GaryJones In that case, maybe you could submit an alternative PR for this ? I don't mind removing the "can get you banned" parts in favour of the code of conduct, but then we should adjust the CoC as it doesn't contain any grounds on which to ban someone for violating copyright or using AI. |
Tips for Successful PRsWe welcome contributions from everyone, and want your PR to have the best chance of being reviewed and merged. Here are a few tips that will help:
By following these tips, you’ll save time for both yourself and the maintainers — and increase the likelihood that your contribution can be merged smoothly. |
@GaryJones Okay, I like the approach, but that still doesn't give us the means to ban people under the CoC for wasting our time with AI-generated PRs. In my opinion, the paragraph about AI generated code is nowhere near strong enough about how problematic this is. It's also missing the part about copyright and licensing. This is pussy-footing, which, to me, is not good enough.
Higher quality ? Well... that very much depends on the contributor....
Clear, self-written explanations will make it more straight-forward for reviewers to understand what you are trying to do.
Similar to the above, I'd suggest replacing "easy" with some other phrasing. This is ablist language. |
There are two overlapping issues here.
The Tips section here handles 1. - even if it needs some strong guidance around copyright / licensing, etc. I don't think we need to be explicit about 2, but we can refer to the CoC. If someone submits a low quality/AI PR, and doesn't take the advice / warning on board, and submits a new PR with the same low quality, then we can take steps at that point if needed. We're the maintainers. We don't need the explicit threat when we've already advised them of what they need to do (and can point them to the tips section) after the first PR. We can agree on wording for a GH saved reply if we want to streamline that feedback. Here's some stronger wording: Tips for Successful PRsWe welcome contributions from everyone, and want your PR to have the best chance of being reviewed and merged. To help with this, please keep the following in mind:
By following these tips, you’ll save time for both yourself and the maintainers — and increase the likelihood that your contribution can be merged smoothly. |
Includes a pull request template which also warns against this.
For the rationale behind this, please read the text in the CONTRIBUTING guide.