WP/GetMetaSingle: simplify code using two class constants #2631
+50
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoprimo
force-pushed
the
update-get-meta-single
branch
from
00496d4 to
2d204ca
Compare
Now that support for PHP < 7.2 has been dropped in PR 2614, we can simplify the sniff code by defining the two different function signature formats as class constants. This was not possible before as PHP < 5.6 did not support defining class constants as arrays.
rodrigoprimo
force-pushed
the
update-get-meta-single
branch
from
2d204ca to
e331fe6
Compare
dingo-d
reviewed
Oct 17, 2025
| * These functions use 'key' as the parameter name at position 2 and | ||
| * 'single' as the parameter name at position 3. | ||
| * | ||
| * @since 3.2.0 |
There was a problem hiding this comment.
Is the since tag correct? 3.2.0 has been released already.
There was a problem hiding this comment.
Thanks for the review, @dingo-d!
Is the since tag correct? 3.2.0 has been released already.
Ops, my bad. It is fixed now.
rodrigoprimo
force-pushed
the
update-get-meta-single
branch
from
2f9ae1b to
a09975d
Compare
jrfnl
reviewed
Oct 17, 2025
| */ | ||
| const METRIC_NAME = 'get_*meta() function called with $single parameter'; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Can the order of these constants please be reversed ?
To me, the logical order would be to go from generic to more specific.
And even if that would be too arbitrary, we could use alphabetical order and that would still result in the same: the GENERIC_META_FUNCTIONS_FORMAT first, the SPECIFIC_META_FUNCTIONS_FORMAT constant second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that support for PHP < 7.2 has been dropped in PR #2614, we can simplify the sniff code by defining the two different function signature formats as class constants. This was not possible before, as PHP < 5.6 did not support defining class constants as arrays.
Suggested changelog entry
N/A