Publishing next packages: remove commit hash from version #74589
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Jan 13, 2026
|
Size Change: 0 B Total Size: 3.05 MB ℹ️ View Unchanged
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
nextpackages are published with a version string like:There is the
--preidstring that saysnext.06ee73755, it includes the git commit SHA, and there is the.0suffix which is a prerelease version auto-incremented by Lerna.The problem with this is that it's not clear which of two adjacent
nextreleases has higher precedence. Is it7.37.1-next.06ee73755.0or7.37.1-next.ba3aee3a2.0? The semver rules say that the two hash strings are to be compared as strings, in lexicographic order. That means that the06ee73755version is considered older thanba3aee3a2because'0' < 'b'. But it fact they were published in the opposite order! Upgrades in consumerpackage.jsonfiles will be unreliable, as we noticed in Automattic/jetpack#46397 (comment)This patch changes the versioning to:
The part that matters for comparisons is the
.0suffix which is auto-incremented by Lerna on each release. And the SHA commit is only after the+sign.