Core Data: Improve blocks cache in useEntityBlockEditor #75400
+85
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace WeakMap-based parsed blocks cache with a Map keyed by a stable string (kind:name:id) that validates content before reuse. This avoids re-parsing the same content when navigating away from an entity and back, since the cache key no longer relies on object identity. The new cache stores both content and blocks, validating that the cached content matches the current content before returning cached blocks. This preserves block clientIds across navigation, which is critical for selection restoration. Add tests validating cache preservation across unmount/remount and cache invalidation on content changes. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
added
the
[Type] Code Quality
|
Size Change: -11 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #75371
What?
Replace WeakMap-based parsed blocks cache with a Map keyed by stable entity identity (kind:name:id). This improves cache behavior when navigating between entities. There's no big visible impact, maybe it's a small performance improvement but it's mandatory to be able to restore selection properly after entity navigation (see linked PR)
Why?
The previous WeakMap approach relied on object identity for cache keys. When navigating away from an entity and back, the entity record object reference could differ, causing a cache miss and unnecessary re-parsing of identical content. This prevented proper selection restoration after navigation.
How?
WeakMaptoMapwith string keykind:name:idTesting Instructions
Run the test suite:
npx wp-scripts test-unit-js --config test/unit/jest.config.js --testPathPattern="packages/core-data/src/test/entity-provider"All 4 tests in useEntityBlockEditor should pass: