Skip to content

Fix: Treat HTTP 410 as dead link in provider status mappings (#5466) #5471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Chavandeep wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix: Treat HTTP 410 as dead link in provider status mappings (#5466) #5471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions api/api/utils/check_dead_links/provider_status_mappings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@

@dataclass
class StatusMapping:
# Status codes that don't clearly indicate live/dead
unknown: tuple[int] = (429, 403)

# Status codes that indicate a working link
live: tuple[int] = (200,)

# Status codes that indicate a dead link (should be filtered out)
dead: tuple[int] = (404, 410, 451, 500, 502, 503, 504)


provider_status_mappings = defaultdict(
StatusMapping,
Expand Down
5 changes: 5 additions & 0 deletions api/test/unit/utils/test_check_dead_links.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,8 @@ def test_mset_and_expire_for_responses(is_cache_reachable, cache_name, request):
"Redis connect failed, cannot cache link liveness.",
]
)

def test_410_status_is_marked_as_dead():
from api.utils.check_dead_links.provider_status_mappings import StatusMapping
mapping = StatusMapping()
assert 410 in mapping.dead
Loading