Skip to content

Skip stylesheets with empty href attributes in Site Health audit #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theaminuli wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Skip stylesheets with empty href attributes in Site Health audit #2281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c23fc3
Handle empty href in blocking assets audit
theaminuli Nov 27, 2025
e41bf61
Fix: skip empty stylesheet href values in asset audit
theaminuli Nov 27, 2025
69985a3
Add test for enqueued style with empty href
theaminuli Nov 27, 2025
756a8aa
Fix whitespace in test-audit-enqueued-assets.php
theaminuli Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/performance-lab/includes/site-health/audit-enqueued-assets/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ function perflab_aea_audit_blocking_assets(): array {
}

$href = $processor->get_attribute( 'href' );
if ( ! is_string( $href ) ) {
if ( ! is_string( $href ) || '' === trim( $href ) ) {
continue;
}

Expand Down
22 changes: 22 additions & 0 deletions ...mance-lab/tests/includes/site-health/audit-enqueued-assets/test-audit-enqueued-assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,12 @@ public function test_perflab_aea_audit_enqueued_styles(): void {
wp_dequeue_style( 'style3' );
wp_enqueue_style( 'style-print', 'https://print-style.com', array(), null, 'print' );
wp_enqueue_style( 'style-no-href', 'https://no-href-style.com', array(), null );
/**
* Enqueue style with empty href
*
* @see https://github.com/WordPress/performance/issues/2278
*/
wp_enqueue_style( 'style-empty-href', 'https://empty-href-style.com', array(), null );

// Filter to remove href attribute from a specific style handle.
add_filter(
Expand All @@ -176,6 +182,14 @@ static function ( $tag, $handle ) {
if ( 'style-no-href' === $handle ) {
$tag = str_replace( 'href=\'https://no-href-style.com\'', ' ', $tag );
}

if ( 'style-empty-href' === $handle ) {
$tag = str_replace(
'href=\'https://empty-href-style.com\'',
"href=''",
$tag
);
}
return $tag;
},
10,
Expand Down Expand Up @@ -242,6 +256,14 @@ static function ( $item ) {
}
);
$this->assertEmpty( $no_href_style );

$empty_href_style = array_filter(
$assets['styles'],
static function ( $item ) {
return 'https://empty-href-style.com' === $item['src'];
}
);
$this->assertEmpty( $empty_href_style );
}

/**
Expand Down