wp-now: Recognize when running in WebContainers environment and use the correct URL#150
Open
wp-now: Recognize when running in WebContainers environment and use the correct URL#150
Conversation
adamziel
commented
Jan 26, 2024
packages/wp-now/src/start-server.ts
Outdated
| body: body as string, | ||
| }; | ||
|
|
||
| data.headers['host'] = options.absoluteUrl |
Collaborator
Author
There was a problem hiding this comment.
This should be handled by webcontainers, not wp-now, and removed from here.
adamziel
commented
Jan 26, 2024
packages/wp-now/src/config.ts
Outdated
| return getCodeSpaceURL(port); | ||
| } | ||
| if (isWebContainer()) { | ||
| return HostURL.parse('http://localhost:' + port).toString(); |
Collaborator
Author
There was a problem hiding this comment.
This returns a http:// URL when it should return a https:// URL
adamziel
force-pushed
the
webcontainers-support
branch
from
420ec01 to
8a53ccb
Compare
adamziel
pushed a commit
that referenced
this pull request
Apr 15, 2024
Improvements to #150 with fixes related to updates for wp-now in WebContainer Can be retargetting to `trunk` if you want to close the other PR ## Testing Instructions Visit https://stackblitz.com/edit/node and run ```bash npx @wp-now/wp-now@some-version start ``` WP-Now should load in your browser
johnhooks
pushed a commit
to johnhooks/playground-tools
that referenced
this pull request
Oct 11, 2024
## Description Sets up the correct build pipeline for all parts of Playground and PHP.wasm. This enables a public release of the [Playground API](WordPress/wordpress-playground#149) npm package! I've been [struggling](WordPress/wordpress-playground#146) with [this](WordPress/wordpress-playground#70) for [a while](WordPress/wordpress-playground#150) and couldn't understand what's so hard. NX made it apparent – look at this dependency graph! <img width="1291" alt="CleanShot 2023-03-16 at 23 16 26@2x" src="https://user-images.githubusercontent.com/205419/225764795-7fa8e972-09f8-41ef-aac2-1c96bd100ea0.png"> No wonder it's been almost impossible to set everything up by hand! ## Usage Start with `yarn install` ### Shortcuts To start a copy of `wasm.wordpress.net` locally, run `yarn run dev`. To build it, run `yarn run build`. ### Fully qualified commands In reality, these `yarn run` commands are just triggering the underlying project's nx `dev` and `build` commands: ```bash nx dev playground-website nx build playground-website ``` Here's a few more interesting commands: ```bash # Build and run PHP.wasm CLI nx start php-wasm-cli # Build latest WordPress releases nx recompile-wordpress:all playground-remote # Recompile PHP 5.6 - 8.2 releases to .wasm for web nx recompile-php:all php-wasm-web # Recompile PHP 5.6 - 8.2 releases to .wasm for node nx recompile-php:all php-wasm-node # Builds markdown files for readthedocs site nx build docs-site # Builds the Playground Client npm package nx build playground-client ``` ## NX is the tool Playground needed from the outset It's ridiculous how many problems this solves: * The build pipeline is explicitly defined and easy to modify * Tasks only run once their dependencies are ready * The dev mode works and is fast * The build works and is fast * We get CI checks to confirm the entire build process still works (which solves WordPress#150) * Cross-package TypeScript just works * There are linters and formatters (which solves WordPress#14) * Documentation is correctly generated from the latest built artifacts * There are nice generators for bootstraping new packages and moving the existing ones around * There are checks to ensure the private `php-wasm-common` package is not imported by anything else than `php-wasm-web` and `php-wasm-node` ## Next steps * Add Lerna to harness package publishing * Additional developer documentation for the nx-based flow Related to WordPress/wordpress-playground#148 and WordPress/wordpress-playground#147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description TBD