Open
Conversation
This ensures that the example in the repository is tested, and accounts for any discovered edge cases. Currently, there's no support for the `pull_request` event `labelled` type, so the label has no affect.
This makes a few adjustments to the suggested workflow file in the example to account for running within the action repository itself. All differences are noted with inline comments.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This updates the workflow that runs the Props Bot action within this repository to better match the example.
Why?
This ensures that the example in the repository is tested, and accounts for any discovered edge cases.
Currently, there's no support for the
pull_requesteventlabelledtype, so the label has no affect. So there's no way to manually generate a list of props. This is important when a pull request originates from a fork.How?
The
./example.props-bot.ymlfile has been copied into the.github/workflows/test-action.ymlone.A few changes have been made, each being accompanied by an inline comment that notes and explains the change for future syncs.