Tests: Add PHPUnit tests for helper and utility functions #328
+1,417
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
priethor
changed the title
Add 159 tests covering acf-helper-functions.php (136 tests) and acf-utility-functions.php (23 tests) with 222 assertions total. Helper function tests cover: - acf_is_empty/acf_not_empty with numeric edge cases - acf_uniqid counter and prefix behavior - acf_merge_attributes class/style concatenation - Filter enable/disable/get/set operations - acf_idval/acf_maybe_idval ID extraction - acf_format_numerics/acf_numval type conversion - acf_idify/acf_slugify/acf_punctify string formatting - acf_strlen with line breaks and multibyte chars - acf_sanitize_request_args type handling and XSS prevention - acf_sanitize_files_array single and multiple file handling - acf_maybe_unserialize with class blocking security Utility function tests cover: - acf_new_instance/acf_get_instance singleton pattern - acf_register_store/acf_get_store data management - acf_get_path/acf_get_url path resolution - acf_include path handling behavior All tests use data providers for comprehensive edge case coverage and include documentation for non-obvious behavior.
priethor
force-pushed
the
add/helper-utility-function-tests
branch
from
1ca2bb9 to
c2fb444
Compare
22 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #328 +/- ##
============================================
+ Coverage 16.68% 17.22% +0.53%
Complexity 4410 4410
============================================
Files 291 291
Lines 36995 36995
============================================
+ Hits 6173 6372 +199
+ Misses 30822 30623 -199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #315.
Adds PHPUnit test coverage for SCF helper and utility functions in
acf-helper-functions.phpandacf-utility-functions.php.Why
Helper functions provide foundational utilities used throughout SCF (empty checks, sanitization, filters, string formatting). Utility functions manage core patterns like singletons, stores, and path resolution. Tests ensure these building blocks work correctly.
How
Adding 159 tests covering:
acf_is_empty,acf_not_empty)Testing Instructions
Run the test suite:
./vendor/bin/phpunit --filter "Test_ACF_Helper_Functions|Test_ACF_Utility_Functions"