Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #355 +/- ##
============================================
- Coverage 53.84% 52.65% -1.20%
Complexity 4423 4423
============================================
Files 298 298
Lines 39468 39468
============================================
- Hits 21251 20780 -471
- Misses 18217 18688 +471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Seems to be passing now though for that PR?
|
|
Yeah, the last commit apparently changed the coverage so it wouldn't fail. Here's an example of the run where it did fail https://github.com/WordPress/secure-custom-fields/runs/60370170867 I'm not exactly sure why it differed so much between those two commits. |
There was a problem hiding this comment.
Pull request overview
Updates Codecov configuration to exclude the repository’s bin/ directory (CLI/infrastructure scripts) from coverage calculations, so overall project coverage reflects unit-testable application code rather than integration-oriented orchestration scripts.
Changes:
- Add
bin/to theignore:list in.codecov.ymlto remove it from Codecov project coverage totals.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - '*.min.css' | ||
| - '*.min.js' | ||
| - '.wp-env' | ||
| - 'bin/' # CLI/infrastructure scripts - integration code with external APIs |
There was a problem hiding this comment.
The ignore list uses bare directory names (e.g., 'build', 'dist', 'docs') without a trailing slash. For consistency and to avoid any pattern-matching edge cases, consider changing 'bin/' to match the existing style (e.g., 'bin' or an explicit glob like 'bin/**').
| - 'bin/' # CLI/infrastructure scripts - integration code with external APIs | |
| - 'bin' # CLI/infrastructure scripts - integration code with external APIs |

Summary
bin/directory from Codecov coverage calculationsThe
bin/directory contains CLI and infrastructure scripts that make HTTP requests to external APIs (GitHub REST/GraphQL). These are integration scripts that are inherently difficult to unit test without extensive HTTP mocking.See #354 as an example - the
codecov/patchcheck passes (confirming the testable parsing logic has coverage), butcodecov/projectfails because the CLI orchestration code inbin/isn't covered.Test plan
bin/files toward project coverage