Skip to content

Fix media modal crash on WP 7.0 due to attachment filters wrapper change #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kraftbj wants to merge 1 commit into
base: trunk
Choose a base branch
from
+17 −2
Open

Fix media modal crash on WP 7.0 due to attachment filters wrapper change #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions assets/src/js/_acf-media.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,23 @@
},

customizeFilters: function ( toolbar ) {
// vars
var filters = toolbar.get( 'filters' );
// Get the AttachmentFilters view from the toolbar.
// WP < 7.0: toolbar.get('filters') returns the AttachmentFilters view directly.
// WP 7.0+: toolbar.get('filters') returns a wrapper View; the
// AttachmentFilters view is nested inside its subviews.
var filtersView = toolbar.get( 'filters' );
var filters = filtersView;

if ( filtersView && ! filtersView.filters ) {
// WP 7.0+: find the AttachmentFilters view in the container's subviews.
var subviews = filtersView.views ? filtersView.views.get() : [];
for ( var i = 0; i < subviews.length; i++ ) {
if ( subviews[ i ].filters ) {
filters = subviews[ i ];
break;
}
}
}

// image
if ( this.get( 'type' ) == 'image' ) {
Expand Down
Loading