Improve identifier and string escaping in the legacy driver#321
Draft
Improve identifier and string escaping in the legacy driver#321
Conversation
JanJakes
force-pushed
the
translator-escaping-fixes
branch
from
86ea87d to
d02b6d1
Compare
JanJakes
force-pushed
the
translator-escaping-fixes
branch
from
d02b6d1 to
b260d23
Compare
JanJakes
changed the title
JanJakes
changed the title
Use parameterized queries and PDO::quote() consistently for all string literals processed by the translator.
JanJakes
force-pushed
the
translator-escaping-fixes
branch
from
b260d23 to
2f325db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve escaping consistency in the legacy SQLite translator:
quote_identifier()for all identifier interpolations (table names, column names, index names, trigger names) in SQL queries, token values, and DDL reconstruction output.PDO::quote()for all string literals processed by the translator.See added tests for more details.