Avoid duplicate warnings

Author: westonruter

src/wp-includes/class-wp-dependencies.php

@@ -104,6 +104,18 @@ class WP_Dependencies {
 	 */
 	private $queued_before_register = array();
 
+	/**
+	 * List of IDs for dependencies encountered which themselves have missing dependencies.
+	 *
+	 * A dependency handle is added to this list when it is discovered to have missing dependencies. At this time, a
+	 * warning is emitted with {@see _doing_it_wrong()}. The handle is then added to this list, so that duplicate
+	 * warnings don't occur.
+	 *
+	 * @since 7.0.0
+	 * @var string[]
+	 */
+	private $dependencies_with_missing_dependencies = array();
+
 	/**
 	 * Processes the items and dependencies.
 	 *
@@ -207,11 +219,14 @@ public function all_deps( $handles, $recursion = false, $group = false ) {
 			if ( ! isset( $this->registered[ $handle ] ) ) {
 				$keep_going = false; // Item doesn't exist.
 			} elseif ( count( $missing_dependencies ) > 0 ) {
-				_doing_it_wrong(
-					__METHOD__,
-					$this->get_dependency_warning_message( $handle, $missing_dependencies ),
-					'7.0.0'
-				);
+				if ( ! in_array( $handle, $this->dependencies_with_missing_dependencies, true ) ) {
+					_doing_it_wrong(
+						__METHOD__,
+						$this->get_dependency_warning_message( $handle, $missing_dependencies ),
+						'7.0.0'
+					);
+					$this->dependencies_with_missing_dependencies[] = $handle;
+				}
 				$keep_going = false; // Item requires dependencies that don't exist.
 			} elseif ( $this->registered[ $handle ]->deps && ! $this->all_deps( $this->registered[ $handle ]->deps, true, $new_group ) ) {
 				$keep_going = false; // Item requires dependencies that don't exist.

src/wp-includes/class-wp-script-modules.php

@@ -70,6 +70,17 @@ class WP_Script_Modules {
 		'high',
 	);
 
+	/**
+	 * List of IDs for script modules encountered which have missing dependencies.
+	 *
+	 * An ID is added to this list when it is discovered to have missing dependencies. At this time, a warning is
+	 * emitted with {@see _doing_it_wrong()}. The ID is then added to this list, so that duplicate warnings don't occur.
+	 *
+	 * @since 7.0.0
+	 * @var string[]
+	 */
+	private $modules_with_missing_dependencies = array();
+
 	/**
 	 * Registers the script module if no script module with that script module
 	 * identifier has already been registered.
@@ -724,16 +735,19 @@ private function sort_item_dependencies( string $id, array $import_types, array
 		// If the item requires dependencies that do not exist, fail.
 		$missing_dependencies = array_diff( $dependency_ids, array_keys( $this->registered ) );
 		if ( count( $missing_dependencies ) > 0 ) {
-			_doing_it_wrong(
-				__METHOD__,
-				sprintf(
+			if ( ! in_array( $id, $this->modules_with_missing_dependencies, true ) ) {
+				_doing_it_wrong(
+					__METHOD__,
+					sprintf(
 					/* translators: 1: Script module ID, 2: Comma-separated list of missing dependency IDs. */
-					__( 'The script module "%1$s" was enqueued with dependencies that are not registered: %2$s.' ),
-					$id,
-					implode( ', ', $missing_dependencies )
-				),
-				'7.0.0'
-			);
+						__( 'The script module "%1$s" was enqueued with dependencies that are not registered: %2$s.' ),
+						$id,
+						implode( ', ', $missing_dependencies )
+					),
+					'7.0.0'
+				);
+				$this->modules_with_missing_dependencies[] = $id;
+			}
 
 			return false;
 		}