Skip to content

Capture errors emitted while applying wp_template_enhancement_output_buffer filters #10310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Capture errors emitted while applying wp_template_enhancement_output_buffer filters #10310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion src/wp-includes/template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,22 @@ function wp_finalize_template_enhancement_output_buffer( string $output, int $ph

$filtered_output = $output;

// TODO: Also capture exceptions?
$error_log = array();
$display_errors = ini_get( 'display_errors' );
if ( $display_errors ) {
ini_set( 'display_errors', 0 );
set_error_handler(
static function ( int $level, string $message, ?string $file = null, ?int $line = null, ?array $context = null ) use ( &$error_log ) {
if ( error_reporting() & $level ) {
$error_log[] = compact( 'level', 'message', 'file', 'line', 'context' );
}
return false;
},
E_ALL
);
}

/**
* Filters the template enhancement output buffer prior to sending to the client.
*
Expand All @@ -962,5 +978,37 @@ function wp_finalize_template_enhancement_output_buffer( string $output, int $ph
* @param string $filtered_output HTML template enhancement output buffer.
* @param string $output Original HTML template output buffer.
*/
return (string) apply_filters( 'wp_template_enhancement_output_buffer', $filtered_output, $output );
$filtered_output = (string) apply_filters( 'wp_template_enhancement_output_buffer', $filtered_output, $output );

if ( $display_errors ) {
foreach ( $error_log as $error ) {
switch ( $error['level'] ) {
case E_USER_NOTICE:
$type = 'Notice';
break;
case E_USER_DEPRECATED:
$type = 'Deprecated';
break;
case E_USER_WARNING:
$type = 'Warning';
break;
default:
$type = 'Error';
}
$displayed_error = sprintf( "<br />\n<b>%s</b>: %s", $type, $error['message'] );
if ( null !== $error['file'] ) {
$displayed_error .= sprintf( ' in <b>%s</b>', $error['file'] );
if ( null !== $error['line'] ) {
$displayed_error .= sprintf( ' on line <b>%d</b>', $error['line'] );
}
}
$displayed_error .= '<br />';

$filtered_output .= $displayed_error;
}
restore_error_handler();
ini_set( 'display_errors', 1 );
}

return $filtered_output;
}
Loading