Skip to content

Twenty Ten: fix "Older posts" and "Newer posts" links for archive pages when in ascending order #10359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Twenty Ten: fix "Older posts" and "Newer posts" links for archive pages when in ascending order #10359

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f73edc8
Check query order in loop.php
sabernhardt Oct 17, 2025
d83213d
Coding standards fix
sabernhardt Oct 17, 2025
5209dc0
Add missing checks for `$prev_link` and `$next_link`
sabernhardt Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/wp-content/themes/twentyten/loop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,25 @@
?>

<?php // Display navigation to next/previous pages when applicable. ?>
<?php if ( $wp_query->max_num_pages > 1 ) : ?>
<?php
if ( $wp_query->max_num_pages > 1 ) :
$order = get_query_var( 'order', 'DESC' );
$is_desc = ( 'DESC' === $order );

$new_posts_text = __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyten' );
$old_posts_text = __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyten' );

$prev_link = $is_desc ? get_next_posts_link( $old_posts_text ) : get_previous_posts_link( $old_posts_text );
$next_link = $is_desc ? get_previous_posts_link( $new_posts_text ) : get_next_posts_link( $new_posts_text );
?>
<div id="nav-above" class="navigation">
<div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyten' ) ); ?></div>
<div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyten' ) ); ?></div>
<?php if ( $prev_link ) : ?>
<div class="nav-previous"><?php echo wp_kses_post( $prev_link ); ?></div>
<?php endif; ?>

<?php if ( $next_link ) : ?>
<div class="nav-next"><?php echo wp_kses_post( $next_link ); ?></div>
<?php endif; ?>
</div><!-- #nav-above -->
<?php endif; ?>

Expand Down Expand Up @@ -205,7 +220,12 @@
<?php // Display navigation to next/previous pages when applicable. ?>
<?php if ( $wp_query->max_num_pages > 1 ) : ?>
<div id="nav-below" class="navigation">
<div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyten' ) ); ?></div>
<div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyten' ) ); ?></div>
<?php if ( $prev_link ) : ?>
<div class="nav-previous"><?php echo wp_kses_post( $prev_link ); ?></div>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuses the variables assigned earlier in the file, within the same $wp_query->max_num_pages > 1 condition.

<?php endif; ?>

<?php if ( $next_link ) : ?>
<div class="nav-next"><?php echo wp_kses_post( $next_link ); ?></div>
<?php endif; ?>
</div><!-- #nav-below -->
<?php endif; ?>
Loading