Skip to content

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Oct 21, 2025

I ran npm run sync-gutenberg-packages -- --dist-tag=latest again and there are more changes. This is strange because I ran the command last night and added all the changes to #10355.

Edit: more info: the failures also happened on another branch that didn't have my commit, so these failures are not related to my commit. https://github.com/WordPress/wordpress-develop/actions/runs/18676543569/job/53247624017?pr=10357

Better diffs:

image image

Trac ticket: https://core.trac.wordpress.org/ticket/64117


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Oct 21, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ellatrix, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ellatrix
Copy link
Member Author

I'm going to commit this to unblock everyone.

pento pushed a commit that referenced this pull request Oct 21, 2025
These arrays were updated through `npm run sync-gutenberg-packages -- --dist-tag=latest`.
Tests started failing after [61009]. They pass with these changes, see #10371.

See #64117.

git-svn-id: https://develop.svn.wordpress.org/trunk@61012 602fd350-edb4-49c9-b593-d223f7449a82
@aaronjorbin
Copy link
Member

Still investigating, but I unpacking the arrays, the changes are:

for src/wp-includes/assets/script-loader-packages.min.php

  • edit-post.min.js no longer has a dependency on wp-admin-ui and wp-views
  • edit-widgets.min.js no longer has a dependency on wp-admin-ui
  • editor.min.js no longer has a dependency on wp-admin-ui
  • views.min.js has a version bump

For src/wp-includes/assets/script-modules-packages.min.php

  • Adding interactivity-router/full-page.min.js
  • Adding block-library/accordion/view.min.js

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Oct 21, 2025
These arrays were updated through `npm run sync-gutenberg-packages -- --dist-tag=latest`.
Tests started failing after [61009]. They pass with these changes, see WordPress/wordpress-develop#10371.

See #64117.
Built from https://develop.svn.wordpress.org/trunk@61012


git-svn-id: http://core.svn.wordpress.org/trunk@60348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Oct 21, 2025
These arrays were updated through `npm run sync-gutenberg-packages -- --dist-tag=latest`.
Tests started failing after [61009]. They pass with these changes, see WordPress/wordpress-develop#10371.

See #64117.
Built from https://develop.svn.wordpress.org/trunk@61012


git-svn-id: https://core.svn.wordpress.org/trunk@60348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@ellatrix
Copy link
Member Author

Looks correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants