Improve single comment endpoint read permissions checks#10525
Improve single comment endpoint read permissions checks#10525adamsilverstein wants to merge 19 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
The various assertions could do with assertSame and for the tests with multiple assertions a different message for each assertion.
src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Weston Ruter <westonruter@gmail.com>
|
@peterwilsoncc I went ahead and committed what we have. I would be in favor of backporting this to 6.9, what do you think? |
|
FWIW I support backporting to 6.9, but defer to a proper committer review/approval there. |
Trac ticket: https://core.trac.wordpress.org/ticket/44157
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.