Skip to content

Fix fatal error on revisions with post meta of type array #10560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LAPSrj wants to merge 4 commits into from
Closed

Fix fatal error on revisions with post meta of type array #10560

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30e6860
Fix fatal error on revisions with post meta of type array
LAPSrj Nov 26, 2025
2786262
use maybe_serialize
LAPSrj Dec 1, 2025
57c6e21
Merge branch 'trunk' into LAPSrj/trunk
westonruter Dec 12, 2025
a7e0854
Add test case that reproduces failure without fix
westonruter Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/revision.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ function wp_save_post_revision( $post_id ) {
$post_has_changed = false;

foreach ( array_keys( _wp_post_revision_fields( $post ) ) as $field ) {
if ( normalize_whitespace( $post->$field ) !== normalize_whitespace( $latest_revision->$field ) ) {
if ( normalize_whitespace( serialize( $post->$field ) ) !== normalize_whitespace( serialize( $latest_revision->$field ) ) ) {
$post_has_changed = true;
break;
}
Expand Down
Loading