Skip to content

Fatal error when wxr_cdata() is called with non-string value #10595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbhalodia wants to merge 2 commits into
base: trunk
Choose a base branch
from
+4 −0
Open

Fatal error when wxr_cdata() is called with non-string value #10595

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee4170b
Typecast the input param to string for typesaftey and fix fatal
hbhalodia Dec 4, 2025
ca33f76
Early return if the incoming data is not a string
hbhalodia Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/wp-admin/includes/export.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,8 @@ function export_wp( $args = array() ) {
* @return string
*/
function wxr_cdata( $str ) {
$str = (string) $str;
Copy link
Member

@westonruter westonruter Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be safer:

Suggested change
$str = (string) $str;
if ( ! is_string( $str ) ) {
$str = '';
}

Copy link
Member

@westonruter westonruter Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of even, why not just:

Suggested change
$str = (string) $str;
if ( ! is_string( $str ) ) {
return '';
}

If the value is an empty string, there's nothing needing to be wrapped in a CDATA section.

Copy link
Author

@hbhalodia hbhalodia Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


if ( ! wp_is_valid_utf8( $str ) ) {
$str = utf8_encode( $str );
}
Expand Down
Loading