fix #64318 Refactor emoji.js to use Set for ignored icons #10603
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| args = args || {}; | ||
| const ignored = new Set([ | ||
| 'a9', 'ae', '2122', | ||
| '2194', '2195', '2196', '2197', '2198', '2199', '21a9', '21aa', |
There was a problem hiding this comment.
These are the new characters introduced in this PR:
'2195', '2196', '2197', '2198', '2199', '21a9', '21aa',
| 'a9', 'ae', '2122', | ||
| '2194', '2195', '2196', '2197', '2198', '2199', '21a9', '21aa', | ||
| '2660', '2663', '2665', '2666', |
There was a problem hiding this comment.
| 'a9', 'ae', '2122', | |
| '2194', '2195', '2196', '2197', '2198', '2199', '21a9', '21aa', | |
| '2660', '2663', '2665', '2666', | |
| 'a9', // COPYRIGHT SIGN | |
| 'ae', // REGISTERED SIGN | |
| '2122', // TRADE MARK SIGN | |
| '2194', // LEFT RIGHT ARROW | |
| '2195', // UP DOWN ARROW | |
| '2196', // NORTH WEST ARROW | |
| '2197', // NORTH EAST ARROW | |
| '2198', // SOUTH EAST ARROW | |
| '2199', // SOUTH WEST ARROW | |
| '21a9', // LEFTWARDS ARROW WITH HOOK | |
| '21aa', // RIGHTWARDS ARROW WITH HOOK | |
| '2660', // BLACK SPADE SUIT | |
| '2663', // BLACK CLUB SUIT | |
| '2665', // BLACK HEART SUIT | |
| '2666', // BLACK DIAMOND SUIT |
| ext: browserSupportsSvgAsImage() ? settings.svgExt : settings.ext, | ||
| className: args.className || 'emoji', | ||
| callback: function( icon, options ) { | ||
| // Ignore some standard characters that TinyMCE recommends in its character map. |
There was a problem hiding this comment.
This comment is obsolete. We should update the comment to explain why now these characters are ignored.
2 participants
added more arrow symbol codes to be ignored from being parsed as emoji
Trac ticket: 64318