Global Styles: Lift classic block restrictions by youknowriad · Pull Request #10623 · WordPress/wordpress-develop

youknowriad · 2025-12-12T15:27:34Z

Backports changes from WordPress/gutenberg#73971 to lift Global Styles restrictions in classic themes. For more details check the upstream PR.

Trac ticket: https://core.trac.wordpress.org/ticket/64408

github-actions · 2025-12-12T15:27:45Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props youknowriad, isabel_brison, ramonopoly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-12-12T15:45:56Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

tellthemachines

The changeset LGTM overall! Might be good to rebase this so we can test it on top of the recent build changes. I tried spinning up the Playground test env but it's acting a bit flaky; there are two custom background menu items instead of the fonts one under "Appearance" 😅

tellthemachines · 2026-01-05T23:35:03Z

src/wp-includes/block-editor.php

+		'__unstableType' => 'user',
+		'isGlobalStyles' => false,
+	);
+


After the build change this will be duplicated between here and gutenberg block editor settings. We might have to move things around a bit in Gutenberg so gutenberg_get_block_editor_settings doesn't end up being used in Core, or else we define Gutenberg as the source of truth for this and remove it from Core.

Yes, this could be an improvement at some point, but the change of build tool doesn't really impact this much outside making it easier to unify more things.

ramonjd

Generally LGTM

I'm not familiar with the work behind this so take my comments with as much salt as you can handle

src/wp-includes/class-wp-theme-json.php

src/wp-includes/global-styles-and-settings.php

ramonjd · 2026-01-06T06:37:33Z

src/wp-includes/global-styles-and-settings.php

+	$tree = WP_Theme_JSON_Resolver::resolve_theme_file_uris( WP_Theme_JSON_Resolver::get_merged_data() );

-	if ( empty( $types ) && ! $supports_theme_json ) {
-		$types = array( 'variables', 'presets', 'base-layout-styles' );


Just checking that things will still work for anyone using the deprecated 'base-layout-styles' type?

Would a backwards compat test in pThemeJson.php be appropriate?

ramonjd · 2026-01-06T06:44:09Z

src/wp-includes/class-wp-theme-json-resolver.php

-		 * theme, the extra condition for whether $theme is the active theme is
-		 * present here.
-		 */
-		if ( $theme->get_stylesheet() === get_stylesheet() && ! wp_theme_has_theme_json() ) {


So now we query for all themes (active or inactive, classic or block), not just themes with theme.json support?

Is the $theme->get_stylesheet() === get_stylesheet() no longer valid? Or will the terms ($theme->get_stylesheet()) below be empty?

Yeah, I think the first part of the condition was unnecessary, we're explicitly passing a theme. I don't see why this particular function would need to only work for the current theme.

@SInCE

Restore historical @SInCE annotations that were removed and add new 7.0.0 annotations documenting the deprecation of 'base-layout-styles' type and the addition of the new `base_layout_styles` option for classic themes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Change the Fonts submenu index from 8 to 9 to avoid collision with the Widgets menu, which also uses index 8 for classic themes in wp_widgets_add_menu(). Since the widgets menu is registered later via the _admin_menu hook, it was overwriting the Fonts entry. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

github-actions · 2026-01-12T12:19:15Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61473
GitHub commit: fd2693d

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

westonruter · 2026-01-12T18:30:43Z

This commit breaks a couple things:

Live Preview in the Customizer
The CSS cascade.

See Trac comment and repro steps.

youknowriad self-assigned this Dec 12, 2025

youknowriad force-pushed the update/lift-global-styles-restrictions branch 2 times, most recently from 5127b85 to c1ea2a2 Compare December 15, 2025 10:21

youknowriad mentioned this pull request Dec 15, 2025

Classic Themes: Enable Fonts and thus global styles WordPress/gutenberg#73971

Merged

github-actions bot mentioned this pull request Dec 16, 2025

PHP backports for WP 7.0 WordPress/gutenberg#74043

Open

tellthemachines reviewed Jan 5, 2026

View reviewed changes

ramonjd mentioned this pull request Jan 6, 2026

E2E tests: restore removal of settings path in preload tests WordPress/gutenberg#74375

Merged

ramonjd reviewed Jan 6, 2026

View reviewed changes

youknowriad added 4 commits January 12, 2026 10:46

Global Styles: Lift classic block restrictions

29f11d7

Fix unit tests

7d61223

Disable layout styles in classic themes

957376a

Keep theme.json agnostic from active theme

e0c7362

youknowriad force-pushed the update/lift-global-styles-restrictions branch from 1d25062 to e0c7362 Compare January 12, 2026 09:46

youknowriad and others added 2 commits January 12, 2026 10:50

github-actions bot closed this Jan 12, 2026

youknowriad deleted the update/lift-global-styles-restrictions branch January 12, 2026 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Global Styles: Lift classic block restrictions#10623

Global Styles: Lift classic block restrictions#10623
youknowriad wants to merge 6 commits intoWordPress:trunkfrom
youknowriad:update/lift-global-styles-restrictions

youknowriad commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

tellthemachines left a comment

Uh oh!

tellthemachines Jan 5, 2026

Uh oh!

youknowriad Jan 12, 2026

Uh oh!

ramonjd left a comment

Uh oh!

Uh oh!

Uh oh!

ramonjd Jan 6, 2026

Uh oh!

ramonjd Jan 6, 2026

Uh oh!

youknowriad Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

westonruter commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

youknowriad commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

tellthemachines left a comment

Choose a reason for hiding this comment

Uh oh!

tellthemachines Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

youknowriad Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

ramonjd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ramonjd Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

ramonjd Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

youknowriad Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

westonruter commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 12, 2025 •

edited

Loading