Skip to content

Early filter invalid hosts in wp_http_validate_url() #10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manhphuc wants to merge 11 commits into
base: trunk
Choose a base branch
from
Open

Early filter invalid hosts in wp_http_validate_url() #10669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b89bec6
HTTP API: Early filter invalid hosts in wp_http_validate_url()
manhphuc Dec 30, 2025
1439d45
Validate non-IP hostnames early in wp_http_validate_url
manhphuc Dec 30, 2025
fc38d7a
HTTP: Early reject invalid hostnames in wp_http_validate_url()
manhphuc Dec 30, 2025
6c7eccb
Tests: fix inline alignment to satisfy PHPCS
manhphuc Dec 30, 2025
d8d86bd
Tests: remove duplicate IP case and fix array formatting
manhphuc Dec 30, 2025
aa5990c
Tests: fix array alignment for PHPCS
manhphuc Dec 30, 2025
fe877fd
HTTP: compute IPv4 host earlier
manhphuc Dec 31, 2025
0ad1fab
Update http.php
manhphuc Jan 2, 2026
889fe26
HTTP: use strict false check for filter_var()
manhphuc Jan 2, 2026
897b851
HTTP: avoid early invalid-host return for IPv4 addresses
manhphuc Jan 2, 2026
9f70512
HTTP: Avoid rejecting hosts with underscore subdomains
manhphuc Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/wp-includes/http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,15 @@ function wp_http_validate_url( $url ) {
$host = trim( $parsed_url['host'], '.' );

if ( ! $same_host ) {
if (
function_exists( 'filter_var' )
&& defined( 'FILTER_VALIDATE_DOMAIN' )
&& defined( 'FILTER_FLAG_HOSTNAME' )
&& ! filter_var( $host, FILTER_VALIDATE_IP )
&& ! filter_var( $host, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME )
) {
return false;
}
if ( preg_match( '#^(([1-9]?\d|1\d\d|25[0-5]|2[0-4]\d)\.){3}([1-9]?\d|1\d\d|25[0-5]|2[0-4]\d)$#', $host ) ) {
$ip = $host;
} else {
Expand Down
3 changes: 3 additions & 0 deletions tests/phpunit/tests/http/http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,9 @@
'url' => 'https://example.com:81/caniload.php',
'cb_safe_ports' => 'callback_remove_safe_ports',
),
'underscore_in_hostname' => array(

Check warning on line 569 in tests/phpunit/tests/http/http.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Array double arrow not aligned correctly; expected 23 space(s) between "'underscore_in_hostname'" and double arrow, but found 1.
'url' => 'https://foo_bar.example.com/',
),
);
}

Expand Down
Loading