-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Insert block template skip link via HTML API, minify CSS, remove JS. #10676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rutviksavsani
wants to merge
34
commits into
WordPress:trunk
Choose a base branch
from
rutviksavsani:refact/insert-skip-link-via-html
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+259
−92
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
8e7719a
Insert block template skip link via HTML API, minify CSS, remove JS.
rutviksavsani 7e29956
remove extra checks for block template.
rutviksavsani 908f6a9
Add type and return type to the function.
rutviksavsani d6278d3
Update translators comment.
rutviksavsani 9a73e67
Add extra checks for get_attribute link target.
rutviksavsani a62dffb
update function doc comment.
rutviksavsani 43c4b01
Remove the duplication check and tag closers check.
rutviksavsani ce8885a
css concat but make it still readable.
rutviksavsani cd9e029
Remove single-use private method
westonruter a194ca8
Add since tag to wp_enqueue_block_template_skip_link()
westonruter 6b7841c
address feedback.
rutviksavsani 0bb3ec4
Add missing path data for stylesheet
westonruter c340b2c
Leverage assertEqualHTML
westonruter eff4489
Add test case for removal of the_block_template_skip_link from wp_footer
westonruter b00b244
Tweak comment
westonruter 1ae2bb2
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter d179f23
Fix swapped test names
westonruter 540b526
Replace while loop with if statement
westonruter 746e686
Use data provider
westonruter 45c26b8
Add test cases for malformed IDs
westonruter c565ff9
Remove unnecessary variable
westonruter ce5b88e
Use esc_url() instead of esc_attr()
westonruter 8b83d4e
Block template skip link handling
rutviksavsani d066dc4
Add tests for block template skip link
rutviksavsani 64ff9d1
Remove the extra processor loop and use seek to insert link.
rutviksavsani 64a8b4a
Merge branch 'WordPress:trunk' into refact/insert-skip-link-via-html
rutviksavsani 350b57c
Fix URL for wp-block-template-skip-link
westonruter b1afb70
Debug: Reduce phpunit-tests for debugging
westonruter 3ed9039
Revert "Debug: Reduce phpunit-tests for debugging"
westonruter 61711e2
Add wp-block-template-skip-link-css to $ignored_styles
westonruter 999acca
Update docs for _block_template_add_skip_link()
westonruter 0db64ac
Fix comment
westonruter b219ac5
Merge branch 'trunk' into refact/insert-skip-link-via-html
westonruter 9f62b62
Merge branch 'trunk' into refact/insert-skip-link-via-html
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| .skip-link.screen-reader-text { | ||
| border: 0; | ||
| clip-path: inset(50%); | ||
| height: 1px; | ||
| margin: -1px; | ||
| overflow: hidden; | ||
| padding: 0; | ||
| position: absolute !important; | ||
| width: 1px; | ||
| word-wrap: normal !important; | ||
rutviksavsani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| .skip-link.screen-reader-text:focus { | ||
| background-color: #eee; | ||
| clip-path: none; | ||
| color: #444; | ||
| display: block; | ||
| font-size: 1em; | ||
| height: auto; | ||
| left: 5px; | ||
| line-height: normal; | ||
| padding: 15px 23px 14px; | ||
| text-decoration: none; | ||
| top: 5px; | ||
| width: auto; | ||
| z-index: 100000; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.