Skip to content

64805 Admin Reskin: Dismissible notices should use different Dashicon close icon#11173

Open
nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
nirav7707:64805-updaet-notic-dismiss-icon
Open

64805 Admin Reskin: Dismissible notices should use different Dashicon close icon#11173
nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
nirav7707:64805-updaet-notic-dismiss-icon

Conversation

@nirav7707
Copy link

@nirav7707 nirav7707 marked this pull request as ready for review March 5, 2026 10:12
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @mathias7am.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props niravsherasiya7707, shailu25, huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@nirav7707
Copy link
Author

Screenshot 2026-03-05 at 3 43 24 PM Updated notice dismissal button icon.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mathias7am
Copy link

Tested 'add user' functionality: correct dashicon is visible.

Context

OS : Win11
Browser : Firefox
WP: 7.0-beta2-20260305.033903

Screenshot 2026-03-05 at 12-15-42 WordPress Playground

@shail-mehta
Copy link
Member

@mathias7am Could you Please Connect you WordPress.org account with github account?

@shail-mehta
Copy link
Member

  • Dismiss icon is showing correct with this PR.
Before After
before-patch after-patch

@huzaifaalmesbah
Copy link
Member

Before:
Huzaifa-20260306155907

After:
Huzaifa-20260306155747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants