Skip to content

Docs: Fix @param type for get_posts()#11179

Open
rodrigoprimo wants to merge 1 commit intoWordPress:trunkfrom
rodrigoprimo:fix-get-posts-param-type
Open

Docs: Fix @param type for get_posts()#11179
rodrigoprimo wants to merge 1 commit intoWordPress:trunkfrom
rodrigoprimo:fix-get-posts-param-type

Conversation

@rodrigoprimo
Copy link

The $args parameter is passed through wp_parse_args(), which accepts both arrays and query strings. This updates the @param type from array to array|string to reflect this, consistent with other functions like wp_list_categories() and get_terms().

Trac ticket: https://core.trac.wordpress.org/ticket/64813


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

The `$args` parameter is passed through `wp_parse_args()`, which accepts both arrays and query strings. Update the `@param` type from `array` to `array|string` to reflect this, consistent with other functions like `wp_list_categories()` and `get_terms()`.
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rodrigosprimo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

* @see WP_Query::parse_query()
*
* @param array $args {
* @param array|string $args {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, wp_parse_args() can take an object too: string|array|object. However, I'm not sure we want to necessarily encourage that. Just because you can pass something doesn't mean you should. The same could be said for string.

*
* @param array $args {
* @param array|string $args {
* Optional. Arguments to retrieve posts. See WP_Query::parse_query() for all available arguments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Optional. Arguments to retrieve posts. See WP_Query::parse_query() for all available arguments.
* Optional. Arguments to retrieve posts. See WP_Query::parse_query() for all available arguments.
* A query string may also be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants