Preserve target="_blank" in Biographical Info and Taxonomy Description#6866
Preserve target="_blank" in Biographical Info and Taxonomy Description#6866nirajgiriXD wants to merge 9 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nirajgiri9860@googlemail.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
This change will affect the behaviour of all |
|
@martinkrcho You are right; changing the |
|
@martinkrcho Could you please take a look at the PR and let me know if the new changes are satisfactory? |
|
@nirajgiriXD I prefer this approach to the previous one. It affects only a limited number of filters. Would you be able to provide unit tests or provide instructions for manual testing (in the Trac ticket)? |
|
@martinkrcho I've added the testing instructions along with some screenshots to the PR description. |
|
Closed in favor of #7792 |
|
closed in favor of #7792 |
Description
This PR ensures that
target="_blank"is preserved in the Biographical Info and Taxonomy Description fields to maintain the intended link behavior.Testing Instructions
Biographical Info
/wp-admin/profile.phpAbout Yourself > Biographical Infosection add a link that includestargetattribute and save it, for example:targetattribute is preserved.targetattribute will be present and work as expected.Taxonomy Description
/wp-admin/edit-tags.php?taxonomy=categoryand select any category to edit.Descriptionsection add a link that includestargetattribute and save it, for example:targetattribute is preserved.targetattribute will be present and work as expected.Trac ticket: https://core.trac.wordpress.org/ticket/12056