Skip to content

WP Package: Replace keyCode with key in key event handling in the wp folder#9359

Open
R1shabh-Gupta wants to merge 1 commit intoWordPress:trunkfrom
R1shabh-Gupta:refactor/event-key-wp-folder
Open

WP Package: Replace keyCode with key in key event handling in the wp folder#9359
R1shabh-Gupta wants to merge 1 commit intoWordPress:trunkfrom
R1shabh-Gupta:refactor/event-key-wp-folder

Conversation

@R1shabh-Gupta
Copy link

@R1shabh-Gupta R1shabh-Gupta commented Jul 30, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/63759

This PR replaces the deprecated keyCode property with key in key event handlers within the wp folder.


Note

I'm not sure whether the virtual keyboard keys need to be replaced (check dfw.js). I haven't made any changes to them yet. Please let me know if this also needs to be updated.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@R1shabh-Gupta R1shabh-Gupta changed the title Replace keyCode with key in key event handling in the wp folder WP Package: Replace keyCode with key in key event handling in the wp folder Jul 31, 2025
@R1shabh-Gupta R1shabh-Gupta marked this pull request as ready for review July 31, 2025 12:47
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rishabhwp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant