Skip to content

Users: Preserve entered values on User Form #9407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+38 −9
Open

Users: Preserve entered values on User Form #9407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2e7bcf
Users: Preserve entered values on Network Add User form after validat…
SainathPoojary Aug 8, 2025
0712579
Users: Preserve entered values on Add Existing User form after valida…
SainathPoojary Aug 11, 2025
347a90a
Users: Fix formatting inconsistencies
SainathPoojary Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/wp-admin/network/user-new.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@
}
}

$username = '';
$email = '';
if ( isset( $_REQUEST['action'] ) && 'add-user' === $_REQUEST['action'] && ! empty( $add_user_errors ) && is_wp_error( $add_user_errors ) ) {
if ( isset( $_POST['user'] ) && is_array( $_POST['user'] ) ) {
$username = isset( $_POST['user']['username'] ) ? wp_unslash( $_POST['user']['username'] ) : '';
$email = isset( $_POST['user']['email'] ) ? wp_unslash( $_POST['user']['email'] ) : '';
}
}

$message = '';
if ( isset( $_GET['update'] ) ) {
if ( 'added' === $_GET['update'] ) {
Expand Down Expand Up @@ -139,11 +148,11 @@
<table class="form-table" role="presentation">
<tr class="form-field form-required">
<th scope="row"><label for="username"><?php _e( 'Username' ); ?> <?php echo wp_required_field_indicator(); ?></label></th>
<td><input type="text" class="regular-text" name="user[username]" id="username" autocapitalize="none" autocorrect="off" maxlength="60" required="required" /></td>
<td><input type="text" class="regular-text" name="user[username]" id="username" autocapitalize="none" autocorrect="off" maxlength="60" required="required" value="<?php echo esc_attr( $username ); ?>" /></td>
</tr>
<tr class="form-field form-required">
<th scope="row"><label for="email"><?php _e( 'Email' ); ?> <?php echo wp_required_field_indicator(); ?></label></th>
<td><input type="email" class="regular-text" name="user[email]" id="email" required="required" /></td>
<td><input type="email" class="regular-text" name="user[email]" id="email" required="required" value="<?php echo esc_attr( $email ); ?>" /></td>
</tr>
<tr class="form-field">
<td colspan="2" class="td-full"><?php _e( 'A password reset link will be sent to the user via email.' ); ?></td>
Expand Down
34 changes: 27 additions & 7 deletions src/wp-admin/user-new.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,31 @@
if ( isset( $_REQUEST['action'] ) && 'adduser' === $_REQUEST['action'] ) {
check_admin_referer( 'add-user', '_wpnonce_add-user' );

$user_details = null;
$user_email = wp_unslash( $_REQUEST['email'] );
$user_details = null;
$redirect_args = array();
foreach ( array( 'email', 'role', 'noconfirmation' ) as $redirect_arg ) {
if ( isset( $_REQUEST[ $redirect_arg ] ) ) {
$redirect_args[ $redirect_arg ] = $_REQUEST[ $redirect_arg ];
}
}

$user_email = wp_unslash( $_REQUEST['email'] );

if ( str_contains( $user_email, '@' ) ) {
$user_details = get_user_by( 'email', $user_email );
} else {
if ( current_user_can( 'manage_network_users' ) ) {
$user_details = get_user_by( 'login', $user_email );
} else {
wp_redirect( add_query_arg( array( 'update' => 'enter_email' ), 'user-new.php' ) );
$redirect_args['update'] = 'enter_email';
wp_redirect( add_query_arg( $redirect_args, 'user-new.php' ) );
die();
}
}

if ( ! $user_details ) {
wp_redirect( add_query_arg( array( 'update' => 'does_not_exist' ), 'user-new.php' ) );
$redirect_args['update'] = 'does_not_exist';
wp_redirect( add_query_arg( $redirect_args, 'user-new.php' ) );
die();
}

Expand Down Expand Up @@ -469,23 +478,34 @@
<input name="action" type="hidden" value="adduser" />
<?php wp_nonce_field( 'add-user', '_wpnonce_add-user' ); ?>

<?php
$adduser_email = isset( $_GET['email'] ) ? wp_unslash( $_GET['email'] ) : '';
$adduser_role = isset( $_GET['role'] ) ? sanitize_text_field( wp_unslash( $_GET['role'] ) ) : '';
$adduser_noconfirmation = isset( $_GET['noconfirmation'] ) ? wp_unslash( $_GET['noconfirmation'] ) : '';
if ( $adduser_role && ! array_key_exists( $adduser_role, get_editable_roles() ) ) {
$adduser_role = '';
}
?>
<table class="form-table" role="presentation">
<tr class="form-field form-required">
<th scope="row"><label for="adduser-email"><?php echo esc_html( $label ); ?></label></th>
<td><input name="email" type="<?php echo esc_attr( $type ); ?>" id="adduser-email" class="wp-suggest-user" value="" /></td>
<td><input name="email" type="<?php echo esc_attr( $type ); ?>" id="adduser-email" class="wp-suggest-user" value="<?php echo esc_attr( $adduser_email ); ?>" /></td>
</tr>
<tr class="form-field">
<th scope="row"><label for="adduser-role"><?php _e( 'Role' ); ?></label></th>
<td><select name="role" id="adduser-role">
<?php wp_dropdown_roles( get_option( 'default_role' ) ); ?>
<?php
$adduser_role_default = $adduser_role ? $adduser_role : get_option( 'default_role' );
wp_dropdown_roles( $adduser_role_default );
?>
</select>
</td>
</tr>
<?php if ( current_user_can( 'manage_network_users' ) ) { ?>
<tr>
<th scope="row"><?php _e( 'Skip Confirmation Email' ); ?></th>
<td>
<input type="checkbox" name="noconfirmation" id="adduser-noconfirmation" value="1" />
<input type="checkbox" name="noconfirmation" id="adduser-noconfirmation" value="1" <?php checked( $adduser_noconfirmation, '1' ); ?> />
<label for="adduser-noconfirmation"><?php _e( 'Add the user without sending an email that requires their confirmation' ); ?></label>
</td>
</tr>
Expand Down
Loading