Skip to content

63836: add error codes to wp_die in post.php #9639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CallumBW95 wants to merge 3 commits into from
Closed

63836: add error codes to wp_die in post.php #9639

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dbade3
63836: add error codes to wp_die in post.php
CallumBW95 Aug 27, 2025
01150b5
63836: update 400 error code to 409 instead of 423
CallumBW95 Sep 2, 2025
729e2fe
Apply suggestions from code review
CallumBW95 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/wp-admin/post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,23 +124,23 @@
}

if ( ! $post ) {
wp_die( __( 'You attempted to edit an item that does not exist. Perhaps it was deleted?' ) );
wp_die( __( 'You attempted to edit an item that does not exist. Perhaps it was deleted?' ), 404 );
}

if ( ! $post_type_object ) {
wp_die( __( 'Invalid post type.' ) );
wp_die( __( 'Invalid post type.' ), 400 );
}

if ( ! in_array( $typenow, get_post_types( array( 'show_ui' => true ) ), true ) ) {
wp_die( __( 'Sorry, you are not allowed to edit posts in this post type.' ) );
wp_die( __( 'Sorry, you are not allowed to edit posts in this post type.' ), 403 );
}

if ( ! current_user_can( 'edit_post', $post_id ) ) {
wp_die( __( 'Sorry, you are not allowed to edit this item.' ) );
wp_die( __( 'Sorry, you are not allowed to edit this item.' ), 403 );
}

if ( 'trash' === $post->post_status ) {
wp_die( __( 'You cannot edit this item because it is in the Trash. Please restore it and try again.' ) );
wp_die( __( 'You cannot edit this item because it is in the Trash. Please restore it and try again.' ), 404 );
}

if ( ! empty( $_GET['get-post-lock'] ) ) {
Expand Down Expand Up @@ -239,26 +239,26 @@
check_admin_referer( 'trash-post_' . $post_id );

if ( ! $post ) {
wp_die( __( 'The item you are trying to move to the Trash no longer exists.' ) );
wp_die( __( 'The item you are trying to move to the Trash no longer exists.' ), 404 );
}

if ( ! $post_type_object ) {
wp_die( __( 'Invalid post type.' ) );
wp_die( __( 'Invalid post type.' ), 400 );
}

if ( ! current_user_can( 'delete_post', $post_id ) ) {
wp_die( __( 'Sorry, you are not allowed to move this item to the Trash.' ) );
wp_die( __( 'Sorry, you are not allowed to move this item to the Trash.' ), 403 );
}

$user_id = wp_check_post_lock( $post_id );
if ( $user_id ) {
$user = get_userdata( $user_id );
/* translators: %s: User's display name. */
wp_die( sprintf( __( 'You cannot move this item to the Trash. %s is currently editing.' ), $user->display_name ) );
wp_die( sprintf( __( 'You cannot move this item to the Trash. %s is currently editing.' ), $user->display_name ), 400 );
Copy link
Member

@westonruter westonruter Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the 409 Conflict status can be used here as well, or the even more explicit 423 Locked status: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/423

Suggested change
wp_die( sprintf( __( 'You cannot move this item to the Trash. %s is currently editing.' ), $user->display_name ), 400 );
wp_die( sprintf( __( 'You cannot move this item to the Trash. %s is currently editing.' ), $user->display_name ), 423 );

}

if ( ! wp_trash_post( $post_id ) ) {
wp_die( __( 'Error in moving the item to Trash.' ) );
wp_die( __( 'Error in moving the item to Trash.' ), 500 );
}

wp_redirect(
Expand All @@ -276,19 +276,19 @@
check_admin_referer( 'untrash-post_' . $post_id );

if ( ! $post ) {
wp_die( __( 'The item you are trying to restore from the Trash no longer exists.' ) );
wp_die( __( 'The item you are trying to restore from the Trash no longer exists.' ), 404 );
}

if ( ! $post_type_object ) {
wp_die( __( 'Invalid post type.' ) );
wp_die( __( 'Invalid post type.' ), 400 );
}

if ( ! current_user_can( 'delete_post', $post_id ) ) {
wp_die( __( 'Sorry, you are not allowed to restore this item from the Trash.' ) );
wp_die( __( 'Sorry, you are not allowed to restore this item from the Trash.' ), 403 );
}

if ( ! wp_untrash_post( $post_id ) ) {
wp_die( __( 'Error in restoring the item from Trash.' ) );
wp_die( __( 'Error in restoring the item from Trash.' ), 500 );
}

$sendback = add_query_arg(
Expand All @@ -305,25 +305,25 @@
check_admin_referer( 'delete-post_' . $post_id );

if ( ! $post ) {
wp_die( __( 'This item has already been deleted.' ) );
wp_die( __( 'This item has already been deleted.' ), 404 );
}

if ( ! $post_type_object ) {
wp_die( __( 'Invalid post type.' ) );
wp_die( __( 'Invalid post type.' ), 400 );
}

if ( ! current_user_can( 'delete_post', $post_id ) ) {
wp_die( __( 'Sorry, you are not allowed to delete this item.' ) );
wp_die( __( 'Sorry, you are not allowed to delete this item.' ), 403 );
}

if ( 'attachment' === $post->post_type ) {
$force = ( ! MEDIA_TRASH );
if ( ! wp_delete_attachment( $post_id, $force ) ) {
wp_die( __( 'Error in deleting the attachment.' ) );
wp_die( __( 'Error in deleting the attachment.' ), 500 );
}
} else {
if ( ! wp_delete_post( $post_id, true ) ) {
wp_die( __( 'Error in deleting the item.' ) );
wp_die( __( 'Error in deleting the item.' ), 500 );
}
}

Expand Down
Loading