Skip to content

fix potential fatal error on Interactivity API processing directives … #9641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hugosolar wants to merge 4 commits into from
Closed

fix potential fatal error on Interactivity API processing directives … #9641

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d0212d
fix potential fatal error on Interactivity API processing directives …
hugosolar Aug 27, 2025
19f2afb
fix null checking and add test
hugosolar Nov 7, 2025
c4bc65d
add unit test and fix process directives
hugosolar Nov 7, 2025
20157c9
Remove trailing comma in function call
sirreal Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/wp-includes/interactivity-api/class-wp-interactivity-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,12 @@ private function _process_directives( string $html ) {
array_pop( $tag_stack );
}
} else {
if ( 0 !== count( $p->get_attribute_names_with_prefix( 'data-wp-each-child' ) ) ) {
$each_child_attrs = $p->get_attribute_names_with_prefix( 'data-wp-each-child' );
if ( ! is_countable( $each_child_attrs ) ) {
Copy link
Member

@sirreal sirreal Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a null check here, it's more consistent with other HTML API code:

Suggested change
if ( ! is_countable( $each_child_attrs ) ) {
if ( null === $each_child_attrs ) {

continue;
}

if ( 0 !== count( $each_child_attrs ) ) {
Copy link

@DAreRodz DAreRodz Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure right now, but I think the else block below should execute when $each_child_attrs is null, shouldn't it?

At least that's the behavior in PHP < 8.0, when count() returned 0 if null is passed.

Suggested change
if ( ! is_countable( $each_child_attrs ) ) {
continue;
}
if ( 0 !== count( $each_child_attrs ) ) {
if ( null !== $each_child_attrs && 0 !== count( $each_child_attrs ) ) {

Copy link
Member

@sirreal sirreal Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. I thought it only contained a foreach with another get_attribute_names_with_prefix() but it contains another conditional block.

That other get_attribute_names_with_prefix has the same problem where it lacks a null check.

/*
* If the tag has a `data-wp-each-child` directive, jump to its closer
* tag because those tags have already been processed.
Expand Down
Loading