Skip to content

Comments

Charset: Add explanatory note about what constitutes “valid” UTF-8#9716

Closed
dmsnell wants to merge 2 commits intoWordPress:trunkfrom
dmsnell:charset/add-validity-note-in-docblock
Closed

Charset: Add explanatory note about what constitutes “valid” UTF-8#9716
dmsnell wants to merge 2 commits intoWordPress:trunkfrom
dmsnell:charset/add-validity-note-in-docblock

Conversation

@dmsnell
Copy link
Member

@dmsnell dmsnell commented Sep 2, 2025

Trac ticket: Core-38044

This patch adds a clarifying note about what constitutes a valid UTF-8 byte stream.

Trac ticket: Core-38044

This patch adds a clarifying note about what constitutes a valid UTF-8
byte stream.

Co-authored-by: Arnt Gulbrandsen <arnt@gulbrandsen.priv.no>
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Model-used: Qwen/Qwen3-32B-4bit
Model-usage: Suggested edits to wording of comment.
Github-pr: 9716
Githbu-pr-link: WordPress#9716
Trac-ticket: 38044
Track-ticket-link: https://core.trac.wordpress.org/ticket/38044
@dmsnell dmsnell force-pushed the charset/add-validity-note-in-docblock branch from 5336004 to d188354 Compare September 2, 2025 23:01
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pento pushed a commit that referenced this pull request Sep 2, 2025
This patch adds a clarifying note about what constitutes a valid UTF-8 byte stream. This was brought up in review as a potentially ambiguous term, so a link to the spec has been provided to fix the behavior to the standard.

Developed in #9716
Discussed in https://core.trac.wordpress.org/ticket/38044

Follow-up to [60630].

Props dmsnell, agulbra.
See #38044.


git-svn-id: https://develop.svn.wordpress.org/trunk@60702 602fd350-edb4-49c9-b593-d223f7449a82
@dmsnell
Copy link
Member Author

dmsnell commented Sep 2, 2025

Merged in [60702]

@dmsnell dmsnell closed this Sep 2, 2025
@dmsnell dmsnell deleted the charset/add-validity-note-in-docblock branch September 2, 2025 23:53
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Sep 2, 2025
This patch adds a clarifying note about what constitutes a valid UTF-8 byte stream. This was brought up in review as a potentially ambiguous term, so a link to the spec has been provided to fix the behavior to the standard.

Developed in WordPress/wordpress-develop#9716
Discussed in https://core.trac.wordpress.org/ticket/38044

Follow-up to [60630].

Props dmsnell, agulbra.
See #38044.

Built from https://develop.svn.wordpress.org/trunk@60702


git-svn-id: http://core.svn.wordpress.org/trunk@60038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Sep 3, 2025
This patch adds a clarifying note about what constitutes a valid UTF-8 byte stream. This was brought up in review as a potentially ambiguous term, so a link to the spec has been provided to fix the behavior to the standard.

Developed in WordPress/wordpress-develop#9716
Discussed in https://core.trac.wordpress.org/ticket/38044

Follow-up to [60630].

Props dmsnell, agulbra.
See #38044.

Built from https://develop.svn.wordpress.org/trunk@60702


git-svn-id: https://core.svn.wordpress.org/trunk@60038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
jonnynews pushed a commit to spacedmonkey/wordpress-develop that referenced this pull request Sep 24, 2025
This patch adds a clarifying note about what constitutes a valid UTF-8 byte stream. This was brought up in review as a potentially ambiguous term, so a link to the spec has been provided to fix the behavior to the standard.

Developed in WordPress#9716
Discussed in https://core.trac.wordpress.org/ticket/38044

Follow-up to [60630].

Props dmsnell, agulbra.
See #38044.


git-svn-id: https://develop.svn.wordpress.org/trunk@60702 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant