Skip to content

[Blueprints] Move blueprints.phar to the Blueprints package #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: trunk
Choose a base branch
from

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Aug 7, 2025

Motivation for the change, related issues

The first step to integrating Blueprints with Playground web.

Implementation details

Testing Instructions (or ideally a Blueprint)

@adamziel
Copy link
Collaborator Author

adamziel commented Aug 8, 2025

These webkit failures feel so random. Firefox and Chrome have very few flaky tests, but whenever I skip two more tests in Safari, another set of two random failures emerges. It feels like something is off with Webkit in CI in general. I don't think having a webkit runner ever detected a major Safari-only issue – let me try disabling the webkit runner entirely.

@adamziel
Copy link
Collaborator Author

adamziel commented Aug 8, 2025

I just can’t get the offline mode to work here. It would be easier if we had an exact error message.

Edit: it finally worked! Although the e2e offline mode test required an additional page reload, which means Playground is only offline-ready on the second page load, not on the first one. TBD whether that's new in this PR or already the case.

@adamziel adamziel changed the title [Blueprints] Move V2 runner to the Blueprints package [Blueprints] Move blueprints.phar to the Blueprints package Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant