[CLI] Make messaging clearer for errors and Xdebug IDE integration #2869
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This PR tweaks a couple of strings around Playground CLI messaging noticed by @fellyph and I while discussing Xdebug IDE integration documentation this afternoon,.
Implementation details
This PR:
causea bit clearer by placing a ":" after "caused by".Could not configure Xdebug caused by VS Code IDE integration requested, but no '.vscode' directory was found in the current working directory.(reads a bit strange but seems like one message)Could not configure Xdebug caused by: VS Code IDE integration requested, but no '.vscode' directory was found in the current working directory.(with the added colon, it is clearer we are talking about separate messages)Testing Instructions (or ideally a Blueprint)