Skip to content

Fix phpMyAdmin and Adminer crash on PHP 8.5 #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanJakes merged 1 commit into from
Mar 31, 2026
+3 −14
Merged

Fix phpMyAdmin and Adminer crash on PHP 8.5 #3444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...ts/site-manager/site-database-panel/adminer-extensions/adminer-mysql-on-sqlite-driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
use Throwable;
use WP_SQLite_Driver;
use WP_SQLite_Connection;
use PDO;

SqlDriver::$drivers = array("server" => "MySQL / MariaDB") + SqlDriver::$drivers;

if (!defined('Adminer\DRIVER')) {
Expand Down Expand Up @@ -103,10 +101,8 @@ class Db extends SqlDb {

function attach($server, $username, $password) {
global $wp_env;
$pdo = new PDO('sqlite:' . $wp_env['db']['path']);
$pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
$this->driver = new WP_SQLite_Driver(
new WP_SQLite_Connection(array('pdo' => $pdo)),
new WP_SQLite_Connection(array('path' => $wp_env['db']['path'])),
'wordpress'
);
return $this;
Expand Down
5 changes: 1 addition & 4 deletions packages/playground/tools/src/phpmyadmin/DbiMysqli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use Closure;
use Exception;
use Generator;
use PDO;
use PhpMyAdmin\FieldMetadata;
use PhpMyAdmin\Query\Utilities;
use Throwable;
Expand Down Expand Up @@ -260,10 +259,8 @@ class DbiMysqli implements DbiExtension {

public function connect($user, $password, array $server) {
global $wp_env;
$pdo = new PDO('sqlite:' . $wp_env['db']['path']);
$pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
$this->driver = new WP_SQLite_Driver(
new WP_SQLite_Connection(array('pdo' => $pdo)),
new WP_SQLite_Connection(array('path' => $wp_env['db']['path'])),
'wordpress'
);
return $this->driver;
Expand Down
6 changes: 1 addition & 5 deletions ...ts/site-manager/site-database-panel/adminer-extensions/adminer-mysql-on-sqlite-driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
use Throwable;
use WP_SQLite_Driver;
use WP_SQLite_Connection;
use PDO;

SqlDriver::$drivers = array("server" => "MySQL / MariaDB") + SqlDriver::$drivers;

if (!defined('Adminer\DRIVER')) {
Expand Down Expand Up @@ -103,10 +101,8 @@ class Db extends SqlDb {

function attach($server, $username, $password) {
global $wp_env;
$pdo = new PDO('sqlite:' . $wp_env['db']['path']);
$pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
$this->driver = new WP_SQLite_Driver(
new WP_SQLite_Connection(array('pdo' => $pdo)),
new WP_SQLite_Connection(array('path' => $wp_env['db']['path'])),
'wordpress'
);
return $this;
Expand Down
Loading