[no_entrypoint_imports] Fix dart path #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydneyjodon-wk
commented
Aug 8, 2025
| push: | ||
| branches: | ||
| - master | ||
| pull_request: |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why these tests are running?
3 tasks
matthewnitschke-wk
requested changes
Aug 11, 2025
Co-authored-by: Matthew Nitschke <[email protected]>
Closed
nicbiggs-wk
approved these changes
Aug 14, 2025
btr-rmconsole-2
bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
|
QA+1 CI and tests pass |
Contributor
Author
|
@Workiva/release-management-p |
matthewnitschke-wk
approved these changes
Aug 14, 2025
This was referenced Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Workiva/over_react_codemod#322, I ran into an issue where if
dartis in the name of a file path, it will get caught in theno_entrypoint_importsadditional-check. I think the solution is just to update the regex to escape the..Changes
QA