Fix unstable LDAP connection tests#105
Closed
pavelhoral wants to merge 1 commit intoWrenSecurity:sustaining/5.0.xfrom
Closed
Fix unstable LDAP connection tests#105pavelhoral wants to merge 1 commit intoWrenSecurity:sustaining/5.0.xfrom
pavelhoral wants to merge 1 commit intoWrenSecurity:sustaining/5.0.xfrom
Conversation
Member
Author
|
I am not sure I have fixed anything... seems like the CI pipeline still occasionally fails. |
Member
Author
|
My fix was nonsense. I will open new PR when I am sure I found the underlying issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds additional countdown latch so that the test can be sure the connection has been closed before actually checking it has been closed.
Btw. I was not able to replicate the issue on my computer, but the history of errors here in GH Actions is pretty clear that there was an issue there.