Skip to content

Error handling of Unexpected termination of child #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
woytam wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Error handling of Unexpected termination of child #46

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
957b2b1
Error handling of Unexpected termination of child
woytam Oct 25, 2019
c5aa36f
Update to coding standard
woytam Oct 29, 2019
26e74e3
Update src/Manager/Flexible.php
woytam Dec 13, 2019
9d98b6a
Merge branch 'master' into patch-1
woytam Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/Manager/Flexible.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use React\EventLoop\LoopInterface;
use WyriHaximus\React\ChildProcess\Messenger\Messages\Message;
use WyriHaximus\React\ChildProcess\Messenger\Messenger;
use WyriHaximus\React\ChildProcess\Messenger\ProcessUnexpectedEndException;
use WyriHaximus\React\ChildProcess\Messenger\MessengerInterface;
use WyriHaximus\React\ChildProcess\Pool\ManagerInterface;
use WyriHaximus\React\ChildProcess\Pool\Options;
Expand Down Expand Up @@ -88,7 +89,11 @@ protected function spawn()
$worker->on('message', function ($message) {
$this->emit('message', [$message]);
});
$worker->on('error', function ($error) {
$worker->on('error', function ($error) use ($worker) {
if ($error instanceof ProcessUnexpectedEndException) {
$worker->terminate();
$this->ping();
}
$this->emit('error', [$error]);
});
$this->workerAvailable($worker);
Expand Down Expand Up @@ -116,18 +121,20 @@ protected function spawnAndGetMessenger(callable $current)

public function ping()
{
if (count($this->workers) + $this->startingProcesses < $this->options[Options::MIN_SIZE]) {
for ($i = count($this->workers) + $this->startingProcesses; $i <= $this->options[Options::MIN_SIZE]; $i++) {
$this->spawn();
}
return;
}

foreach ($this->workers as $worker) {
if (!$worker->isBusy()) {
$this->workerAvailable($worker);
return;
}
}

if (count($this->workers) + $this->startingProcesses < $this->options[Options::MIN_SIZE]) {
$this->spawn();
return;
}

if (count($this->workers) + $this->startingProcesses < $this->options[Options::MAX_SIZE]) {
$this->spawn();
}
Expand Down