Skip to content

Fixed some deprecations concerning FulfilledPromise. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartvanhoutte wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed some deprecations concerning FulfilledPromise. #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Pool/Dummy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use Evenement\EventEmitterTrait;
use React\EventLoop\LoopInterface;
use React\Promise\FulfilledPromise;
use React\Promise\PromiseInterface;
use WyriHaximus\React\ChildProcess\Messenger\Messages\Message;
use WyriHaximus\React\ChildProcess\Messenger\Messages\Rpc;
Expand All @@ -30,7 +29,7 @@ public function __construct(ProcessCollectionInterface $processCollection, LoopI
*/
public function rpc(Rpc $message)
{
return new FulfilledPromise();
return \React\Promise\resolve();
}

/**
Expand Down
3 changes: 1 addition & 2 deletions src/Queue/Overflow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace WyriHaximus\React\ChildProcess\Pool\Queue;

use React\Promise\FulfilledPromise;
use React\Promise\PromiseInterface;
use WyriHaximus\React\ChildProcess\Messenger\Messages\Rpc;
use WyriHaximus\React\ChildProcess\Pool\QueueInterface;
Expand Down Expand Up @@ -67,7 +66,7 @@ public function dequeue()
protected function requeue()
{
if ($this->queue->count() === 0) {
return new FulfilledPromise();
return \React\Promise\resolve();
Copy link
Owner

@WyriHaximus WyriHaximus Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably using use function React\Promise\resolve here

}

return \React\Promise\resolve($this->queue->dequeue())->then(function (Rpc $rpc) {
Expand Down