Proper fix for GUI_FitForward callsite using UB#46
Open
stefanriemens wants to merge 1 commit intomasterfrom
Open
Proper fix for GUI_FitForward callsite using UB#46stefanriemens wants to merge 1 commit intomasterfrom
stefanriemens wants to merge 1 commit intomasterfrom
Conversation
…d that takes iterators for no good reason. Instead, use pointer arithmatic instead of iterators - pointing one-past-the-end is valid, so this is is a valid way to fix the original deref-an-end-iterator-is-illegal bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pointer arithmatic instead of iterators. This is still ugly code, but at least it is now valid C++ and, not unimportantly... it actually compiles, as opposed to Ilyass' fix in #39