Open
Conversation
… for line segments when the control points are colocated with the end points. This lets us use bezier2 for all of our edges (even straight ones) and get best-possible-performance for the line segment cases.
computes the subsection of every pavement edge not overlapping with some other pavement edge and creates new .lin files for this. This code verifies that the bezier intersection code is reasonably solid but is missing a few things: 1. No good schema for which lines to use 2. Does not handle overlapping interior edges. 3. Does not merge adjacent edges, which would otherwise be useful for cutting data size.
for relative pavement priority. elimination of hidden edges is covered by "who's on top" logic and we don't need special casing for it.
edges per polygon side.
airport polygon to save edge count. We also need this to do runway support next. Slightly scary is exposing the lowest-export edge choice in the param plane of the airport nodes. Since this is unused now, in theory it'd be UB/broken if anyone was relying on past behavior here.
…y handled and it may cause a silent failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
So in this PR i tried to keep all the features as requested.
Key changes:
WED_SceneryPackExport.cpp : Removed the false argument from the call to WED_DoConvertToForest(). This argument previously corresponded to the in_cmd parameter, which has since been removed from the function signature.
WED_GroupCommands.cpp: Replaced false with nullptr in the constructor call for WED_RingFromImage. This aligns with the constructor’s expectations: the relevant parameters are pointers (create and gcp), and the logic inside the constructor checks indirectly whether they are valid (non-null).