Skip to content

Feature: Custom notification icon #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature: Custom notification icon #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...c/main/java/flutter/overlay/window/flutter_overlay_window/FlutterOverlayWindowPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) {
String overlayTitle = call.argument("overlayTitle");
String overlayContent = call.argument("overlayContent");
String notificationVisibility = call.argument("notificationVisibility");
String notificationIcon = call.argument("notificationIcon");
boolean enableDrag = call.argument("enableDrag");
String positionGravity = call.argument("positionGravity");
Map<String, Integer> startPosition = call.argument("startPosition");
Expand All @@ -101,6 +102,9 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) {
WindowSetup.overlayContent = overlayContent == null ? "" : overlayContent;
WindowSetup.positionGravity = positionGravity;
WindowSetup.setNotificationVisibility(notificationVisibility);
if(notificationIcon!=null) {
WindowSetup.setNotificationIcon(notificationIcon);
}

final Intent intent = new Intent(context, OverlayService.class);
intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/flutter/overlay/window/flutter_overlay_window/OverlayService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ public void onCreate() {
}
PendingIntent pendingIntent = PendingIntent.getActivity(this,
0, notificationIntent, pendingFlags);
final int notifyIcon = getDrawableResourceId("mipmap", "launcher");
final int notifyIcon = getDrawableResourceId(WindowSetup.notificationIconResType, WindowSetup.notificationIconName);
Notification notification = new NotificationCompat.Builder(this, OverlayConstants.CHANNEL_ID)
.setContentTitle(WindowSetup.overlayTitle)
.setContentText(WindowSetup.overlayContent)
Expand All @@ -358,7 +358,7 @@ private void createNotificationChannel() {
}

private int getDrawableResourceId(String resType, String name) {
return getApplicationContext().getResources().getIdentifier(String.format("ic_%s", name), resType, getApplicationContext().getPackageName());
return getApplicationContext().getResources().getIdentifier(name, resType, getApplicationContext().getPackageName());
}

private int dpToPx(int dp) {
Expand Down
7 changes: 7 additions & 0 deletions android/src/main/java/flutter/overlay/window/flutter_overlay_window/WindowSetup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ public abstract class WindowSetup {
static String positionGravity = "none";
static int notificationVisibility = NotificationCompat.VISIBILITY_PRIVATE;
static boolean enableDrag = false;
static String notificationIconResType = "mipmap";
static String notificationIconName = "ic_launcher";


static void setNotificationVisibility(String name) {
Expand Down Expand Up @@ -98,4 +100,9 @@ static void setGravityFromAlignment(String alignment) {
}

}

static void setNotificationIcon(String notificationIcon) {
notificationIconResType = "drawable";
notificationIconName = notificationIcon;
}
}
5 changes: 5 additions & 0 deletions lib/src/overlay_window.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ class FlutterOverlayWindow {
/// `positionGravity` the overlay postion after drag and default is [PositionGravity.none]
///
/// `startPosition` the overlay start position and default is null
///
/// `notificationIcon` the notification icon (file must be in the android/app/src/main/res/drawable folder)
///
static Future<void> showOverlay({
int height = WindowSize.fullCover,
int width = WindowSize.matchParent,
Expand All @@ -50,6 +53,7 @@ class FlutterOverlayWindow {
bool enableDrag = false,
PositionGravity positionGravity = PositionGravity.none,
OverlayPosition? startPosition,
String? notificationIcon,
}) async {
await _channel.invokeMethod(
'showOverlay',
Expand All @@ -64,6 +68,7 @@ class FlutterOverlayWindow {
"notificationVisibility": visibility.name,
"positionGravity": positionGravity.name,
"startPosition": startPosition?.toMap(),
"notificationIcon" : notificationIcon
},
);
}
Expand Down