Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Google Test-based unit test infrastructure for the injector and menu modules, and replaces ATL-based string conversion with a custom CW2A utility to reduce external dependencies.
- Introduces a custom Windows string conversion class
CW2Afor converting wide-character strings to ANSI - Adds Google Test framework integration and test entry points for both
injectorandmenumodules - Updates the thread ID formatter to use the new conversion utility instead of ATL
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| common/src/conversion/cw2a.hpp | Implements custom CW2A class for wide-char to ANSI conversion |
| common/src/conversion/cw2a.cpp | Source file for CW2A implementation |
| common/CMakeLists.txt | Adds CW2A conversion utility source files to build |
| common/src/logging/formatter/thread_id.hpp | Updates include and usage to use new CW2A utility instead of ATL |
| injector/test/src/main.cpp | Adds Google Test entry point for injector tests |
| injector/test/CMakeLists.txt | Configures test executable for injector module |
| injector/CMakeLists.txt | Adds test subdirectory to build |
| menu/test/src/main.cpp | Adds Google Test entry point for menu tests |
| menu/test/CMakeLists.txt | Configures test executable for menu module |
| menu/CMakeLists.txt | Adds test subdirectory and test file to build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Windows string conversion utility and adds Google Test-based unit test setups for both the
injectorandmenumodules. The main changes are grouped into improvements to string conversion and logging, and enhancements to the testing infrastructure.String conversion and logging improvements:
CW2Aclass incommon/src/conversion/cw2a.hppand its implementation incw2a.cpp, providing a utility for converting wide-character strings (wchar_t*) to ANSI (char*) using Windows APIs. [1] [2]CW2Autility into the thread ID formatter incommon/src/logging/formatter/thread_id.hpp, replacing the previous ATL-based conversion and updating relevant includes. [1] [2]common/CMakeLists.txt) to include the new conversion utility source files.Testing infrastructure enhancements:
injectormodule, including a new test directory, CMake configuration (injector/test/CMakeLists.txt), and a test entry point (injector/test/src/main.cpp). [1] [2] [3]menumodule, including a new test directory, CMake configuration (menu/test/CMakeLists.txt), and a test entry point (menu/test/src/main.cpp). [1] [2] [3] [4]