modesetting: implement everything using libgbm as well as dumb_bo #1396
Conversation
stefan11111
requested review from
a team,
algrid,
callmetango,
cepelinas9000 and
metux
|
@notbabaisyou ping |
| case 16: | ||
| return GBM_FORMAT_RGB565; | ||
| case 30: | ||
| return GBM_FORMAT_ARGB2101010; |
There was a problem hiding this comment.
I know It is offtopic, shouldn't be here to be something smarter? Because all nvida card which i have, only supports xBGR2101010
There was a problem hiding this comment.
I'm not sure what we can do better here.
Do we have any way of querying the format?
| #define MAX(a,b) ((a) > (b) ? (a) : (b)) | ||
|
|
||
| #ifndef GBM_BO_USE_FRONT_RENDERING | ||
| #define GBM_BO_USE_FRONT_RENDERING 0 |
There was a problem hiding this comment.
Wouldn't it make more sense to assign the actual value, distros with older libgbm that don't support the feature would ignore the value anyway.
There was a problem hiding this comment.
We'd be passing flags to libgbm that it doesn't support, and hope that it does the right thing and ignores them.
stefan11111
force-pushed
the
gbm-cursor
branch
from
a65f289 to
ab02776
Compare
|
gbm-only path now works with/without glamor, with/without shadowfb (on my system, at least) |
|
Merge Conflict found |
1 similar comment
|
Merge Conflict found |
Signed-off-by: stefan11111 <[email protected]>
Signed-off-by: stefan11111 <[email protected]>
Signed-off-by: stefan11111 <[email protected]>
Signed-off-by: stefan11111 <[email protected]>
Signed-off-by: stefan11111 <[email protected]>
Signed-off-by: stefan11111 <[email protected]>
…buffers only Signed-off-by: stefan11111 <[email protected]>
… gbm buffers only Signed-off-by: stefan11111 <[email protected]>
stefan11111
force-pushed
the
gbm-cursor
branch
from
cec4d8c to
1a28dbe
Compare
|
@metux @callmetango @cepelinas9000 @notbabaisyou @ONykyf |
Signed-off-by: stefan11111 <[email protected]>
3 participants
Only a proof of concept for now.
libgbm from mesa is a generic buffer management library for gpu buffers.
In the modesetting driver, we also roll our own dumb_bo implementation, so that we don't depend on libgbm.
libgbm supports allocating dumb buffers, as well as "smarter" buffers.
With this, everything that was only implemented with dumb_bo, is now also implemented with libgbm.
The next steps after this are to decouple libgbm from glamor, to allow using it even when we don't have accelerated modesetting.
After that, I think we should remove the dumb_bo implementation, and use libgbm for everything.
While writing this, I also noticed some questionable code, which I wrote some comment about.
Closes: #734