Skip to content

Xtranssock.c: fix format truncation warning #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −2
Open

Xtranssock.c: fix format truncation warning #1405

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
704e92c
Xtranssock.c: fix format truncation warning
clhin Nov 14, 2025
e9add0d
try different approach to fix CI error
clhin Nov 14, 2025
0d14ad0
Fix mistake
clhin Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions os/Xtranssock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ set_sun_path(const char *port, const char *upath, char *path, int abstract)
struct sockaddr_un s;
ssize_t maxlen = sizeof(s.sun_path) - 1;
const char *at = "";

char * buf;
if (!port || !*port || !path)
return -1;

Expand All @@ -638,7 +638,11 @@ set_sun_path(const char *port, const char *upath, char *path, int abstract)

if ((ssize_t)(strlen(at) + strlen(upath) + strlen(port)) > maxlen)
return -1;
snprintf(path, sizeof(s.sun_path), "%s%s%s", at, upath, port);

asprintf(&buf, "%s%s%s", at, upath, port);
strncpy(path, buf, sizeof(s.sun_path)-1);
Copy link
Contributor

@stefan11111 stefan11111 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing needless copies and filling the buffer with extra 0 bytes.

s.sun_path[sizeof(s.sun_path)-1] = '\0';
free(buf);
return 0;
}
#endif
Expand Down