screenint_priv.h: fix signed comparison warnings #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algrid
reviewed
Nov 17, 2025
| */ | ||
| static inline ScreenPtr dixGetScreenPtr(unsigned int idx) { | ||
| if (idx < screenInfo.numScreens) | ||
| if (idx < (unsigned int)screenInfo.numScreens) |
There was a problem hiding this comment.
I wonder what’s the best way of fixing that. Alternatively we could make the index signed. Or make numScreens unsigned if that doesn’t break the ABI.
Contributor
There was a problem hiding this comment.
I think that making the index signed is better, since it gives the compiler more room for optimization.
Contributor
There was a problem hiding this comment.
Actually, I've been planning to make this unsigned some day - but we yet have to make sure this wouldn't cause any ABI break (because it's part of the ABI).
Contributor
Author
|
I think it makes more sense to make numScreens unsigned, but I went with the least potentially disruptive fix for the ABI's sake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates roughly 1500 lines of sign compare warnings